Messages in this thread | | | Date | Wed, 28 Aug 2013 13:09:26 -0600 | From | Tim Gardner <> | Subject | Re: [PATCH net-next 1/1] net: neighbour: Simplify ifdefs around neigh_app_ns() |
| |
On 08/28/2013 12:51 PM, Joe Perches wrote: > On Wed, 2013-08-28 at 12:24 -0600, Tim Gardner wrote: >> Drop a couple of ifdef/endif pairs by moving the ifdef >> surrounding neigh_app_ns() to the interior of neigh_app_ns(). > [] >> This is an admittedly trivial change. I stumbled on it while trying to figure >> out why Ubuntu doesn't have CONFIG_ARPD enabled. > > I'd be more inclined to make neigh_app_ns static inline > in the .h file and remove the EXPORT_SYMBOL >
I thought about that as well, but then you'd have to extern __neigh_notify(), which is currently a static function and large enough to not really be suitable for inlining. Seems like unnecessary churn to me.
rtg -- Tim Gardner tim.gardner@canonical.com
| |