lkml.org 
[lkml]   [2013]   [Aug]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/3] Send cgroup_path in SCM_CGROUP
Hello, Jan.

Can you please cc cgroup maintainers and mailing lists from
MAINTAINERS for cgroup related changes?

On Tue, Aug 27, 2013 at 04:40:00PM +0200, Jan Kaluza wrote:

Also, please describe what change is being made why on each patch.
Repeating the same description is fine but each patch descrption
should be more or less self-sufficient.

> +int scm_get_current_cgroup_path(char **cgroup_path)
> +{
> + int ret = 0;
> +
> + *cgroup_path = kmalloc(PAGE_SIZE, GFP_KERNEL);

PATH_MAX?

> + if (!(*cgroup_path))
> + return -ENOMEM;
> +
> + ret = task_cgroup_path(current, *cgroup_path, PAGE_SIZE);
> + if (ret < 0) {
> + kfree(*cgroup_path);
> + *cgroup_path = NULL;
> + }
> +
> + return ret;
> +}

Other than that, cgroup side looks fine to me. For cgroup bits,

Reviewed-by: Tejun Heo <tj@kernel.org>

Thanks.

--
tejun


\
 
 \ /
  Last update: 2013-08-28 16:21    [W:0.981 / U:0.368 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site