Messages in this thread | | | Date | Wed, 28 Aug 2013 16:54:09 +0800 | From | Xiao Guangrong <> | Subject | Re: [PATCH 08/12] KVM: MMU: introduce nulls desc |
| |
On 08/28/2013 04:40 PM, Gleb Natapov wrote:
>> static unsigned long *__gfn_to_rmap(gfn_t gfn, int level, >> @@ -1200,7 +1221,7 @@ static u64 *rmap_get_first(unsigned long rmap, struct rmap_iterator *iter) >> */ >> static u64 *rmap_get_next(struct rmap_iterator *iter) >> { >> - if (iter->desc) { >> + if (iter->desc && !desc_is_a_nulls(iter->desc)) { >> if (iter->pos < PTE_LIST_EXT - 1) { >> u64 *sptep; >> >> @@ -1212,7 +1233,7 @@ static u64 *rmap_get_next(struct rmap_iterator *iter) >> >> iter->desc = iter->desc->more; >> > I'd rather do: > iter->desc = desc_is_a_nulls(iter->desc) ? NULL : iter->desc; > here and drop two desc_is_a_nulls() checks in this function.
Nice, will do it in the next version. Thanks!
| |