Messages in this thread | | | Date | Tue, 27 Aug 2013 23:33:00 +0000 | From | Eric Wong <> | Subject | Re: [PATCH] epoll: add a reschedule point in ep_free() |
| |
Eric Dumazet <eric.dumazet@gmail.com> wrote: > From: Eric Dumazet <edumazet@google.com> > > ep_free() might iterate on a huge set of epitems and hold > cpu too long. Add two cond_resched() in order to yield cpu > to other tasks. This is safe as we only hold mutexes in > this function. > > Signed-off-by: Eric Dumazet <edumazet@google.com> > Cc: Al Viro <viro@ZenIV.linux.org.uk> > Cc: Theodore Ts'o <tytso@mit.edu>
Seems reasonable. This isn't a remotely hot path and f_op->release runs in a workqueue nowadays (right?).
Acked-by: Eric Wong <normalperson@yhbt.net>
| |