Messages in this thread | | | Date | Tue, 27 Aug 2013 15:12:57 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH v7 02/10] tracing: add basic event trigger framework |
| |
On Mon, 26 Aug 2013 22:55:59 -0500 Tom Zanussi <tom.zanussi@linux.intel.com> wrote:
> diff --git a/kernel/trace/trace.h b/kernel/trace/trace.h > index b1227b9..1733ac9 100644 > --- a/kernel/trace/trace.h > +++ b/kernel/trace/trace.h > @@ -1016,9 +1016,184 @@ extern void trace_event_enable_cmd_record(bool enable); > extern int event_trace_add_tracer(struct dentry *parent, struct trace_array *tr); > extern int event_trace_del_tracer(struct trace_array *tr); > > +extern struct ftrace_event_file *find_event_file(struct trace_array *tr, > + const char *system, > + const char *event);
This patch breaks bisection as you need to remove the static from find_event_file() too.
Also, it adds a lot of warnings like "register_event_command" defined but not used.
My scripts will fail this patch if it adds a warning. No static function should be added without being used.
-- Steve
> + > +static inline void *event_file_data(struct file *filp) > +{ > + return ACCESS_ONCE(file_inode(filp)->i_private); > +} > + > extern struct mutex event_mutex; > extern struct list_head ftrace_events; >
| |