Messages in this thread | | | Date | Tue, 27 Aug 2013 13:55:06 -0500 | From | Felipe Balbi <> | Subject | Re: [PATCH] usb: gadget/composite : Avoid crash with bad gadget drivers |
| |
On Thu, Aug 15, 2013 at 01:40:01AM +0300, Philippe De Swert wrote: > Hi, > > On 12/08/13 21:08, Felipe Balbi wrote: > >On Fri, Aug 09, 2013 at 09:23:08PM +0300, Philippe De Swert wrote: > >>Some bad gadget drivers do not check the return status of usb_add_config. > > > >fix the gadget driver > > As stated in my comment (see below) that is indeed what should > happen. But we cannot fix it in future new gadget drivers, is it thus > not better > to avoid a crash? The gadget driver will not work as expected anyway > when this occurs and the print will at least give an indication why.
if we avoid a crash, we will be decreasing the urgency of fixing the gadget driver bug.
Let's leave it as is. I can't live thinking that maybe in the future there will be gadget drivers doing different things...
-- balbi [unhandled content-type:application/pgp-signature] | |