Messages in this thread | | | Date | Tue, 27 Aug 2013 14:11:58 +0800 | Subject | Re: [PATCH 1/2] mfd: 88pm800: Fix the bug that pdata may be NULL | From | Chao Xie <> |
| |
On Tue, Aug 20, 2013 at 9:40 AM, Samuel Ortiz <sameo@linux.intel.com> wrote: > Hi Xie, > > On Sun, Aug 18, 2013 at 09:27:54PM -0400, Chao Xie wrote: >> User pass platform data to device, and platform data may be >> NULL. > In which case do you get that ? With DT ? > Should rtc_init fail when pdata is NULL ? > > You need to explain that, be it only for us to know if it's a critical > fix or not. > Sorry for late response. If pdata is NULL, the driver will fail. So the error check should be done at the beginning of probe. If (!pdata) return -EINVAL;
Is that OK?
> Cheers, > Samuel. > > -- > Intel Open Source Technology Centre > http://oss.intel.com/
| |