Messages in this thread | | | Date | Tue, 27 Aug 2013 08:06:47 +0200 | From | Andreas Larsson <> | Subject | Re: [PATCH v2] gpio: interrupt consistency check for OF GPIO IRQs |
| |
On 2013-08-26 16:04, Lars Poeschel wrote: > On Monday 26 August 2013 at 13:29:07, Andreas Larsson wrote: >> On 2013-08-26 12:56, Lars Poeschel wrote: >>>> This call to of_irq_find_parent breaks gpiolib-of for SPARC due to >>>> the fact that the function is undefined when !defined(CONFIG_OF_IRQ) >>>> && defined(CONFIG_OF). >>>> >>>> Defining the empty of_irq_find_parent in include/linux/of_irq.h when >>>> !defined(CONFIG_OF_IRQ) instead of the current case when >>>> !defined(CONFIG_OF) would solve the immediate compilation problem. >>> >>> Is this a bug and should be fixed ? >> >> Well, at least as soon as anyone tries to use in a context that does not >> exclude SPARC it creates a bug, so I would say so. There is no reason >> for SPARC to fall between the chairs. This is the first case I am aware >> of that triggers this. > > I also think this should be fixed. > Are you able to do a patch that fixes this and submit to the relevant > people?
Sure!
Cheers, Andreas
| |