lkml.org 
[lkml]   [2013]   [Aug]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
SubjectRe: [trivial PATCH] treewide: Fix printks with 0x%#
From
Date
On Tue, 2013-08-27 at 01:39 -0400, Mike Frysinger wrote:
> On Thursday 25 July 2013 14:53:25 Joe Perches wrote:
> > Using 0x%# emits 0x0x. Only one is necessary.
>
> sounds like a job for checkpatch.pl :)

Here. Submit it yourself...
---
scripts/checkpatch.pl | 12 ++++++++++++
1 file changed, 12 insertions(+)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 9ba4fc4..520f8e7 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -3869,6 +3869,18 @@ sub process {
}
}

+# check for formats with "0x%#"
+ if ($line =~ /"X*"/) {
+ my $fmt = get_quoted_string($line, $rawline);
+ if ($fmt =~ /0x%#/) {
+ if (WARN("REDUNDANT_HEX",
+ "Redundant hex prefix 0x format\n" . $herecurr) &&
+ $fix) {
+ $fixed[$linenr - 1] =~ s/0x%#/%#/g;
+ }
+ }
+ }
+
# Check for misused memsets
if ($^V && $^V ge 5.10.0 &&
defined $stat &&




\
 
 \ /
  Last update: 2013-08-27 08:21    [W:0.044 / U:0.256 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site