lkml.org 
[lkml]   [2013]   [Aug]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 11/18] Hibernate: introduced RSA key-pair to verify signature of snapshot
On Tue, 27 Aug 2013, 13:29:43 +0200, Pavel Machek wrote:
> > > > @@ -1205,6 +1290,10 @@ struct boot_params *efi_main(void *handle, efi_system_table_t *_table,
> > > >
> > > > setup_efi_pci(boot_params);
> > > >
> > > > +#ifdef CONFIG_SNAPSHOT_VERIFICATION
> > > > + setup_s4_keys(boot_params);
> > > > +#endif
> > > > +
> > >
> > > Move ifdef inside the function?
> >
> > OK, I will define a dummy function for non-verification situation.
>
> IIRC you can just put the #ifdef inside the function body.

This is certainly not to be invoked on a frequent basis (and therefore
not on a hot path), but from a more general angle, wouldn't this leave
a(nother) plain "jsr... rts" sequence without any effect other than
burning a few cycles? If the whole function call can be disabled
(ignored) in a certain configuration, it shouldn't call at all, should
it?

Cheers.

l8er
manfred


\
 
 \ /
  Last update: 2013-08-27 15:21    [W:0.063 / U:0.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site