Messages in this thread | | | Date | Tue, 27 Aug 2013 15:09:35 +0530 | From | Aruna Balakrishnaiah <> | Subject | Re: [RFC PATCH v2 06/11] pstore: Add decompression support to pstore |
| |
On Friday 23 August 2013 04:34 AM, Seiji Aguchi wrote: > >> -----Original Message----- >> From: linux-kernel-owner@vger.kernel.org [mailto:linux-kernel-owner@vger.kernel.org] On Behalf Of Aruna Balakrishnaiah >> Sent: Friday, August 16, 2013 9:18 AM >> To: linuxppc-dev@ozlabs.org; tony.luck@intel.com; linux-kernel@vger.kernel.org; keescook@chromium.org >> Cc: jkenisto@linux.vnet.ibm.com; ananth@in.ibm.com; benh@kernel.crashing.org; cbouatmailru@gmail.com; >> mahesh@linux.vnet.ibm.com; ccross@android.com >> Subject: [RFC PATCH v2 06/11] pstore: Add decompression support to pstore >> >> Based on the flag 'compressed' set or not, pstore will decompress the >> data returning a plain text file. If decompression fails for a particular >> record it will have the compressed data in the file which can be >> decompressed with 'openssl' command line tool. > If the decompression fails and openssl doesn't work, the worst case is that users can't read the entry. > In that case, pstore is meaningless at all.
If decompression fails and openssl doesn't work. We have python module zlib to decompress the zlib data. zlib.decompress() should do the trick.
> Also, for users who want to get a single panic message, a compression is not needed. > > So, I think we still have to support non-compression mode. > (IMO, pstore can take kdump as a model. Kdump supports both compression and non-compression mode.) > > But, if you think my comment is outside this patchset, it's OK. > We can make it with a separate patch. > > Seiji > _______________________________________________ > Linuxppc-dev mailing list > Linuxppc-dev@lists.ozlabs.org > https://lists.ozlabs.org/listinfo/linuxppc-dev >
| |