lkml.org 
[lkml]   [2013]   [Aug]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[ 17/74] tracing: Do not call kmem_cache_free() on allocation failure
    Date
    3.10-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Namhyung Kim <namhyung.kim@lge.com>

    commit aaf6ac0f0871cb7fc0f28f3a00edf329bc7adc29 upstream.

    There's no point calling it when _alloc() failed.

    Link: http://lkml.kernel.org/r/1370585268-29169-1-git-send-email-namhyung@kernel.org

    Signed-off-by: Namhyung Kim <namhyung@kernel.org>
    Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    kernel/trace/trace_events.c | 7 +------
    1 file changed, 1 insertion(+), 6 deletions(-)

    --- a/kernel/trace/trace_events.c
    +++ b/kernel/trace/trace_events.c
    @@ -114,7 +114,7 @@ static int __trace_define_field(struct l

    field = kmem_cache_alloc(field_cachep, GFP_TRACE);
    if (!field)
    - goto err;
    + return -ENOMEM;

    field->name = name;
    field->type = type;
    @@ -131,11 +131,6 @@ static int __trace_define_field(struct l
    list_add(&field->link, head);

    return 0;
    -
    -err:
    - kmem_cache_free(field_cachep, field);
    -
    - return -ENOMEM;
    }

    int trace_define_field(struct ftrace_event_call *call, const char *type,



    \
     
     \ /
      Last update: 2013-08-27 05:21    [W:5.207 / U:0.100 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site