lkml.org 
[lkml]   [2013]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2] pinctrl: Pass all configs to driver on pin_config_set()
From
On Thu, Aug 22, 2013 at 3:18 AM, Sherman Yin <syin@broadcom.com> wrote:

> When setting pin configuration in the pinctrl framework, pin_config_set() or
> pin_config_group_set() is called in a loop to set one configuration at a time
> for the specified pin or group.
>
> This patch 1) removes the loop and 2) changes the API to pass the whole pin
> config array to the driver. It is now up to the driver to loop through the
> configs. This allows the driver to potentially combine configs and reduce the
> number of writes to pin config registers.
>
> All c files changed have been build-tested to verify the change compiles and
> that the corresponding .o is successfully generated.
>
> Signed-off-by: Sherman Yin <syin@broadcom.com>
> Reviewed-by: Christian Daudt <csd@broadcom.com>
> Reviewed-by: Matt Porter <matt.porter@linaro.org>

Didn't you get review from Stephen Warren?

> ---
> Please refer to the discussion with Linus W. "[PATCH] ARM: Adds pin config API
> to set all configs in one function" here:
>
> http://lists.infradead.org/pipermail/linux-arm-kernel/2013-May/166567.html
>
> All c files changed have been build-tested to verify the change compiles and
> that the corresponding .o are successfully generated.
>
> [v2] rebased on LinusW's linux-pinctrl.git "devel" branch. Fixed and build-
> tested pinctrl-sunxi.c
> ---
> drivers/pinctrl/mvebu/pinctrl-mvebu.c | 26 +++--
> drivers/pinctrl/pinconf.c | 42 ++++----
> drivers/pinctrl/pinctrl-abx500.c | 187 ++++++++++++++++++---------------
> drivers/pinctrl/pinctrl-at91.c | 48 +++++----
> drivers/pinctrl/pinctrl-bcm2835.c | 43 ++++----
> drivers/pinctrl/pinctrl-exynos5440.c | 113 +++++++++++---------
> drivers/pinctrl/pinctrl-falcon.c | 63 ++++++-----
> drivers/pinctrl/pinctrl-imx.c | 28 ++---
> drivers/pinctrl/pinctrl-mxs.c | 91 ++++++++--------
> drivers/pinctrl/pinctrl-nomadik.c | 125 ++++++++++++----------
> drivers/pinctrl/pinctrl-rockchip.c | 57 ++++++----
> drivers/pinctrl/pinctrl-samsung.c | 17 ++-
> drivers/pinctrl/pinctrl-single.c | 33 ++++--
> drivers/pinctrl/pinctrl-st.c | 11 +-
> drivers/pinctrl/pinctrl-sunxi.c | 95 +++++++++--------
> drivers/pinctrl/pinctrl-tegra.c | 69 ++++++------
> drivers/pinctrl/pinctrl-tz1090-pdc.c | 135 ++++++++++++++----------
> drivers/pinctrl/pinctrl-tz1090.c | 140 +++++++++++++-----------
> drivers/pinctrl/pinctrl-u300.c | 18 ++--
> drivers/pinctrl/pinctrl-xway.c | 119 +++++++++++++--------
> drivers/pinctrl/sh-pfc/pinctrl.c | 42 ++++----
> drivers/pinctrl/vt8500/pinctrl-wmt.c | 54 +++++-----
> include/linux/pinctrl/pinconf.h | 6 +-
> 23 files changed, 889 insertions(+), 673 deletions(-)

Please try to put all the maintainers for the above files on the To: line
so they get a chance to review/ack the patch.

Yours,
Linus Walleij


\
 
 \ /
  Last update: 2013-08-23 20:01    [W:0.104 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site