Messages in this thread | | | Date | Fri, 23 Aug 2013 16:24:23 +0530 | From | Preeti U Murthy <> | Subject | Re: [PATCH 07/10] sched, fair: Optimize find_busiest_queue() |
| |
On 08/23/2013 03:33 PM, Peter Zijlstra wrote: > On Fri, Aug 23, 2013 at 01:41:55PM +0530, Preeti U Murthy wrote: >> Hi Peter, >> >> On 08/19/2013 09:31 PM, Peter Zijlstra wrote: >> >> In the load balancing code, looks to me that >> cpumask_copy(cpus, cpu_active_mask) is not updating the env.cpus at all, >> before calling find_busiest_group(). Am I missing something? >> >> Should not cpumask_copy() below be before we update the env.cpus parameter? > > Nah, its all pointers. >
Yikes! Of course :P
Reviewed-by: Preeti U Murthy <preeti@linux.vnet.ibm.com>
| |