Messages in this thread | | | Date | Thu, 22 Aug 2013 08:27:45 +0100 | From | "Jan Beulich" <> | Subject | Re: Regression: x86/mm: new _PTE_SWP_SOFT_DIRTY bit conflicts with existing use |
| |
>>> On 22.08.13 at 09:03, Cyrill Gorcunov <gorcunov@gmail.com> wrote: > Ok, how about this? > > static inline pte_t pte_swp_mksoft_dirty(pte_t pte) > { > BUG_ON(pte_present(pte)); > return pte_set_flags(pte, _PAGE_SWP_SOFT_DIRTY); > }
Sure, fine with me. Perhaps VM_BUG_ON() or some other similar construct limiting the scope when any extra code gets generated would do too.
But as said, even better would perhaps be to have it act on a swp_entry_t.
Jan
| |