lkml.org 
[lkml]   [2013]   [Aug]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Regression: x86/mm: new _PTE_SWP_SOFT_DIRTY bit conflicts with existing use
>>> On 22.08.13 at 09:03, Cyrill Gorcunov <gorcunov@gmail.com> wrote:
> Ok, how about this?
>
> static inline pte_t pte_swp_mksoft_dirty(pte_t pte)
> {
> BUG_ON(pte_present(pte));
> return pte_set_flags(pte, _PAGE_SWP_SOFT_DIRTY);
> }

Sure, fine with me. Perhaps VM_BUG_ON() or some other similar
construct limiting the scope when any extra code gets generated
would do too.

But as said, even better would perhaps be to have it act on a
swp_entry_t.

Jan



\
 
 \ /
  Last update: 2013-08-22 10:01    [W:0.221 / U:0.540 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site