| Date | Thu, 22 Aug 2013 17:49:43 +0000 | From | Christoph Lameter <> | Subject | Re: [PATCH 02/16] slab: change return type of kmem_getpages() to struct page |
| |
On Thu, 22 Aug 2013, Joonsoo Kim wrote:
> @@ -2042,7 +2042,7 @@ static void slab_destroy_debugcheck(struct kmem_cache *cachep, struct slab *slab > */ > static void slab_destroy(struct kmem_cache *cachep, struct slab *slabp) > { > - void *addr = slabp->s_mem - slabp->colouroff; > + struct page *page = virt_to_head_page(slabp->s_mem); > > slab_destroy_debugcheck(cachep, slabp); > if (unlikely(cachep->flags & SLAB_DESTROY_BY_RCU)) {
Ok so this removes slab offset management. The use of a struct page pointer therefore results in coloring support to be not possible anymore.
I would suggest to have a separate patch for coloring removal before this patch. It seems that the support is removed in two different patches now.
|