lkml.org 
[lkml]   [2013]   [Aug]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/3] x86: don't use echo -e needlessly
From
Date
Can we drop the /bin/?

Max Filippov <jcmvbkbc@gmail.com> wrote:
>-e is not needed to output strings without escape sequences.
>
>Cc: Thomas Gleixner <tglx@linutronix.de>
>Cc: Ingo Molnar <mingo@redhat.com>
>Cc: "H. Peter Anvin" <hpa@zytor.com>
>Cc: x86@kernel.org
>Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
>---
> arch/x86/Makefile | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/arch/x86/Makefile b/arch/x86/Makefile
>index 07639c6..7386e8a 100644
>--- a/arch/x86/Makefile
>+++ b/arch/x86/Makefile
>@@ -95,7 +95,7 @@ endif
>
> ifdef CONFIG_X86_X32
> x32_ld_ok := $(call try-run,\
>- /bin/echo -e '1: .quad 1b' | \
>+ /bin/echo '1: .quad 1b' | \
> $(CC) $(KBUILD_AFLAGS) -c -x assembler -o "$$TMP" - && \
> $(OBJCOPY) -O elf32-x86-64 "$$TMP" "$$TMPO" && \
> $(LD) -m elf32_x86_64 "$$TMPO" -o "$$TMP",y,n)

--
Sent from my mobile phone. Please excuse brevity and lack of formatting.


\
 
 \ /
  Last update: 2013-08-22 17:21    [W:0.055 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site