lkml.org 
[lkml]   [2013]   [Aug]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] documentation/devicetree: Move DT bindigns from gpio to watchdog
On Wed, Aug 21, 2013 at 11:34:00AM -0600, Stephen Warren wrote:
> On 08/21/2013 06:42 AM, Johannes Thumshirn wrote:
> > I accidently put the devicetree bindings for the MEN A21 watchdog driver in
> > Documentation/devicetree/bindings/gpio instead of
> > Documentation/devicetree/bindings/watchdog, this patch addresses this error.
>
> The rename sounds fine, so that part,
> Acked-by: Stephen Warren <swarren@nvidia.com>
>
> However, the binding itself doesn't look right; it appears to have a
> single "gpios" property rather than using separate named xxx-gpios
> properties for different things...

Ok, so I'll need something like the following?

watchdog {
compatible ="men,a021-wdt";
enable-gpios = <&gpio3 9 1>; /* WD_EN */
fast-gpios = <&gpio3 10 1>; /* WD_FAST */
trig-gpios = <&gpio3 11 1>; /* WD_TRIG */
rst0-gpio = <&gpio3 6 1>; /* RST_CAUSE[0] */
rst1-gpio = <&gpio3 7 1>; /* RST_CAUSE[1] */
rst2-gpio = <&gpio3 8 1>; /* RST_CAUSE[2] */
};

Or is there something like of_get_named_gpios(...) so I can put all 3 rst-gpios
into one property? A quick grep only revealed of_get_named_gpio(...).

Thanks,
Johannes


\
 
 \ /
  Last update: 2013-08-22 10:01    [W:0.082 / U:0.276 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site