Messages in this thread | | | Date | Wed, 21 Aug 2013 00:02:55 -0700 (PDT) | Subject | Re: [PATCH] VMXNET3: Add support for virtual IOMMU | From | David Miller <> |
| |
From: Andy King <acking@vmware.com> Date: Tue, 20 Aug 2013 10:33:32 -0700
> We can't just do virt_to_phys() on memory that we pass to the device and > expect it to work in presence of a virtual IOMMU. We need to add IOMMU > mappings for such DMAs to work correctly. Fix that with > pci_alloc_consistent() where possible, or pci_map_single() where the > mapping is short-lived or we don't control the allocation (netdev). > > Also fix two small bugs: > 1) use after free of rq->buf_info in vmxnet3_rq_destroy() > 2) a cpu_to_le32() that should have been a cpu_to_le64() > > Acked-by: George Zhang <georgezhang@vmware.com> > Acked-by: Aditya Sarwade <asarwade@vmware.com> > Signed-off-by: Andy King <acking@vmware.com>
Please use dma_alloc_coherent() (or in fact dma_zalloc_coherent()), dma_map_single() et al., because they are preferred and in particular allow specification of GFP_* flags.
| |