Messages in this thread | | | Date | Mon, 19 Aug 2013 23:59:44 -0700 (PDT) | From | David Rientjes <> | Subject | Re: [RESEND PATCH 2/4] ARM: msm: Re-organize platsmp to make it extensible |
| |
On Mon, 12 Aug 2013, Mark Rutland wrote:
> > static void __init msm_smp_prepare_cpus(unsigned int max_cpus) > > { > > + int cpu, map; > > + unsigned int flags = 0; > > + > > + for_each_present_cpu(cpu) { > > + map = cpu_logical_map(cpu); > > + if (map > ARRAY_SIZE(cold_boot_flags)) { > > + set_cpu_present(cpu, false); > > + __WARN(); > > + continue; > > + } > > + flags |= cold_boot_flags[map];
__WARN() can't be used in generic code because it's possible to have CONFIG_BUG=n, you probably want something like WARN_ON(1) instead.
| |