lkml.org 
[lkml]   [2013]   [Aug]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RESEND PATCH 2/4] ARM: msm: Re-organize platsmp to make it extensible
On Mon, 12 Aug 2013, Mark Rutland wrote:

> > static void __init msm_smp_prepare_cpus(unsigned int max_cpus)
> > {
> > + int cpu, map;
> > + unsigned int flags = 0;
> > +
> > + for_each_present_cpu(cpu) {
> > + map = cpu_logical_map(cpu);
> > + if (map > ARRAY_SIZE(cold_boot_flags)) {
> > + set_cpu_present(cpu, false);
> > + __WARN();
> > + continue;
> > + }
> > + flags |= cold_boot_flags[map];

__WARN() can't be used in generic code because it's possible to have
CONFIG_BUG=n, you probably want something like WARN_ON(1) instead.


\
 
 \ /
  Last update: 2013-08-20 10:01    [W:0.103 / U:0.988 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site