Messages in this thread | | | Subject | Re: [PATCH-SR9700] Merge USB 1.1 Ethernet Adapter SR9700 Device Driver into the Linux Kernel | From | Joe Perches <> | Date | Tue, 20 Aug 2013 13:58:22 -0700 |
| |
On Tue, 2013-08-20 at 22:46 +0200, Francois Romieu wrote: > liujunliang_ljl <liujunliang_ljl@163.com> :
> > + if (i >= SR_SHARE_TIMEOUT) { > > + netdev_err(dev->net, "%s read timed out!", phy ? "phy" : "eeprom");
netdev_<level>, like almost all other printk messages needs a terminating "\n" newline to avoid any possible message interleaving by other printks.
> > + if (!is_valid_ether_addr(addr->sa_data)) { > > + dev_err(&net->dev, "not setting invalid mac address %pM\n", > > + addr->sa_data); > > dev_err(&net->dev, "not setting invalid mac address %pM\n", > addr->sa_data);
prefer netdev_<level> to dev_<level> where possible.
| |