lkml.org 
[lkml]   [2013]   [Aug]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/4] mfd: as3722: introduce regmap support
On Tue, 20 Aug 2013, Florian Lobmaier wrote:

>
> Signed-off-by: Florian Lobmaier <florian.lobmaier@ams.com>
> ---
> drivers/mfd/as3722-regmap.c | 417 +++++++++++++++++++++++++++++++++++++++++++
> 1 files changed, 417 insertions(+), 0 deletions(-)
> create mode 100644 drivers/mfd/as3722-regmap.c

I'll leave the review of this file to Mark, but it should be added
either when you start calling the functions, or at least before they
are used, or else the preceding commits won't build. This would cause
someone a major headache if their bisect landed in the middle of your
patches.

--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2013-08-20 14:21    [W:0.200 / U:0.316 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site