lkml.org 
[lkml]   [2013]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[ 01/39] iscsi-target: Fix tfc_tpg_nacl_auth_cit configfs length overflow
    Date
    3.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Joern Engel <joern@logfs.org>

    commit 0fbfc46fb0b2f543a8b539e94c6c293ebc0b05a6 upstream.

    This patch fixes a potential buffer overflow while processing
    iscsi_node_auth input for configfs attributes within NodeACL
    tfc_tpg_nacl_auth_cit context.

    Signed-off-by: Joern Engel <joern@logfs.org>
    Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/target/iscsi/iscsi_target_configfs.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/target/iscsi/iscsi_target_configfs.c
    +++ b/drivers/target/iscsi/iscsi_target_configfs.c
    @@ -415,7 +415,7 @@ static ssize_t __iscsi_##prefix##_store_
    if (!capable(CAP_SYS_ADMIN)) \
    return -EPERM; \
    \
    - snprintf(auth->name, PAGE_SIZE, "%s", page); \
    + snprintf(auth->name, sizeof(auth->name), "%s", page); \
    if (!strncmp("NULL", auth->name, 4)) \
    auth->naf_flags &= ~flags; \
    else \



    \
     
     \ /
      Last update: 2013-08-02 14:01    [W:4.022 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site