lkml.org 
[lkml]   [2013]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH] acpi_i2c: set MODULE_LICENSE, MODULE_AUTHOR, and MODULE_DESCRIPTION
On Tue Aug 20 13, Rafael J. Wysocki wrote:
> On Monday, August 19, 2013 04:35:29 PM Jerry Snitselaar wrote:
> > On Tue Aug 20 13, Rafael J. Wysocki wrote:
> > > On Monday, August 19, 2013 09:16:14 AM Mika Westerberg wrote:
> > > > On Fri, Aug 16, 2013 at 06:26:35PM -0700, Jerry Snitselaar wrote:
> > > > > Without MODULE_LICENSE set, I get the following with modprobe:
> > > > >
> > > > > acpi_i2c: module license 'unspecified' taints kernel.
> > > > > acpi_i2c: Unknown symbol i2c_new_device (err 0)
> > > > > acpi_i2c: Unknown symbol acpi_dev_get_resources (err 0)
> > > > > acpi_i2c: Unknown symbol acpi_dev_resource_interrupt (err 0)
> > > > > acpi_i2c: Unknown symbol acpi_dev_free_resource_list (err 0)
> > > > >
> > > > > Signed-off-by: Jerry Snitselaar <jerry.snitselaar@oracle.com>
> > > >
> > > > Looks good to me.
> > > >
> > > > Acked-by: Mika Westerbeg <mika.westerberg@linux.intel.com>
> > >
> > > Well, OK, but do we need to be able to build that as a module?
> > >
> > > Maybe it should just be yes or no?
> > >
> > > Rafael
> > >
> >
> > Perhaps have depends on I2C=y and be a bool instead of tristate?
>
> Yes, that's the idea.
>
Does this look okay Mika?

[PATCH] acpi_i2c: do not build as loadable module

Change from tristate to bool, and depend on I2C=y

Signed-off-by: Jerry Snitselaar <jerry.snitselaar@oracle.com>
---
drivers/acpi/Kconfig | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
index 100bd72..183a309 100644
--- a/drivers/acpi/Kconfig
+++ b/drivers/acpi/Kconfig
@@ -181,8 +181,9 @@ config ACPI_DOCK
drive bays such as the IBM Ultrabay and the Dell Module Bay.

config ACPI_I2C
- def_tristate I2C
- depends on I2C
+ bool "I2C"
+ depends on I2C=y
+ default n
help
ACPI I2C enumeration support.

--
1.8.4.rc3.2.g2c2b664

\
 
 \ /
  Last update: 2013-08-20 05:41    [W:0.111 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site