Messages in this thread | | | Date | Fri, 16 Aug 2013 16:55:56 -0600 | From | Stephen Warren <> | Subject | Re: [PATCH v3] hwspinlock/msm: Add support for Qualcomm MSM HW Mutex block |
| |
On 08/14/2013 01:09 PM, Kumar Gala wrote: > Add driver for Qualcomm MSM Hardware Mutex block that exists on newer MSM > SoC (MSM8974, etc).
> diff --git a/Documentation/devicetree/bindings/hwlock/msm-tcsr-mutex.txt b/Documentation/devicetree/bindings/hwlock/msm-tcsr-mutex.txt
> +Required properties: > +- compatible: should be "qcom,tcsr-mutex" > +- reg: Should contain registers location and length of mutex registers > +- reg-names: > + "mutex-base" - string to identify mutex registers > +- qcom,num-locks: the number of locks/mutexes supported
Doesn't the block support any interrupts? I suppose the interrupts property can be optional though even if it does.
Aside from the comments re: reg-names, this binding seems fine.
| |