Messages in this thread | | | Date | Fri, 16 Aug 2013 10:13:38 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH 2/3] Staging: olpc_dcon: replace some magic numbers |
| |
On Thu, Aug 15, 2013 at 09:34:55PM +0200, Jens Frederich wrote: > The 0x42 initialize squence 0x101 is wrong. According to > the specification Bit 8 is reserved, thus not in use. > I removed it.
Really these code changes should be in a separate patch and labeled "Don't set reserved bit." instead of hidden away inside a cleanup patch.
regards, dan carpenter
| |