Messages in this thread | | | Date | Fri, 16 Aug 2013 11:00:09 -0700 | From | Randy Dunlap <> | Subject | Re: [PATCH] usb: phy: am335x-control: make it compile with |
| |
On 08/16/13 08:32, Sebastian Andrzej Siewior wrote: > From: Sebastian Andrzej Siewior <bigeasy@linutronix.de> > > Randy reported this > |drivers/usb/phy/phy-am335x-control.c:45:3: error: implicit declaration > |of function '__WARN' [-Werror=implicit-function-declaration] > > and left it as an excercice to figure out that this happens only with > CONFIG_BUG=n. As a fix I replace it with WARN_ON(). And there is a space > before return so fix this, too. > > Reported-by: Randy Dunlap <rdunlap@infradead.org> > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> --- > drivers/usb/phy/phy-am335x-control.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/phy/phy-am335x-control.c b/drivers/usb/phy/phy-am335x-control.c > index 7597545..22cf07d 100644 > --- a/drivers/usb/phy/phy-am335x-control.c > +++ b/drivers/usb/phy/phy-am335x-control.c > @@ -42,8 +42,8 @@ static void am335x_phy_power(struct phy_control *phy_ctrl, u32 id, bool on) > reg = AM335X_USB1_CTRL; > break; > default: > - __WARN(); > - return; > + WARN_ON(1); > + return; > } > > val = readl(usb_ctrl->phy_reg + reg); >
-- ~Randy
| |