Messages in this thread | | | Date | Fri, 16 Aug 2013 17:13:32 +0200 | Subject | Re: [PATCH 1/5] drivers/gpio/gpio-omap.c: convert comma to semicolon | From | Linus Walleij <> |
| |
On Mon, Aug 12, 2013 at 6:15 PM, Kevin Hilman <khilman@linaro.org> wrote: > Joe Perches <joe@perches.com> writes: > >> On Sat, 2013-08-10 at 17:40 +0200, Julia Lawall wrote: >>> From: Julia Lawall <Julia.Lawall@lip6.fr> >>> Replace a comma between expression statements by a semicolon. >> [] >>> I can't tell if the assignment to ct->regs.mask is really intended to be >>> under the if. The proposed patch preserves the current semantics, but not >>> the current indentation. >> >> I'd suspect more that the indentation is correct >> and the comma use incorrect. >> >> It also looks more like a copy/paste error from >> commit f8b46b583 when the code was restructured >> a bit. >> >> Kevin? > > Yes, looks like a copy/paste error. The comma should simply be replaced > by a semi-colon.
So can I have a patch for this? Pretty please...
Yours, Linus Walleij
| |