lkml.org 
[lkml]   [2013]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH] Fix aio performance regression for database caused by THP
On 08/16/2013 03:04 AM, Kirill A. Shutemov wrote:
> On Thu, Aug 15, 2013 at 12:13:09PM -0600, Khalid Aziz wrote:
>>
>> - if (likely(page != page_head && get_page_unless_zero(page_head))) {
>> + /*
>> + * If this is a hugetlbfs page, it can not be split under
>> + * us. Simply increment refcount for head page
>> + */
>> + if (PageHuge(page)) {
>> + page_head = compound_head(page);
>> + atomic_inc(&page_head->_count);
>> + got = true;
>
> Why not just return here and don't increase indentantion level for rest of
> the function?
>

Good point.

Andrew, I can rework the patch if you would like.

Thanks,
Khalid


\
 
 \ /
  Last update: 2013-08-16 16:41    [W:0.092 / U:0.344 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site