Messages in this thread | | | Date | Fri, 16 Aug 2013 13:00:31 +0200 | From | Michal Hocko <> | Subject | Re: [Bug] Reproducible data corruption on i5-3340M: Please continue your great work! :-) |
| |
On Thu 15-08-13 17:33:28, Linus Torvalds wrote: > On Thu, Aug 15, 2013 at 4:05 PM, Ben Tebulin <tebulin@googlemail.com> wrote: > > > >> Ben, please test. I'm worried that the problem you see is something > >> even more fundamentally wrong with the whole "oops, must flush in the > >> middle" logic, but I'm _hoping_ this fixes it. > > > > It's gone. > > > > Really! > > > > I git-fsck'ed successfully around 30 times in a row. > > And even all the other things still seem to work ;-) > > Goodie. I think I'm just going to commit it (with the speling fixes > for other architectures) asap. It's bigger than I'd like, but it's a > lot simpler than the alternatives of trying to figure out exactly > which call chain got things wrong with the previous confusing model.
I was thinking about teaching __tlb_remove_page to update the range automatically from the given address.
But your patch looks good to me as well.
Feel free to add Reviewed-by: Michal Hocko <mhocko@suse.cz>
Thanks! -- Michal Hocko SUSE Labs
| |