Messages in this thread | | | Date | Fri, 16 Aug 2013 20:15:36 +1000 | From | Alexey Kardashevskiy <> | Subject | Re: [PATCH 2/2] powerpc/iommu: check dev->iommu_group before remove a device from iommu_group |
| |
On 08/16/2013 08:08 PM, Wei Yang wrote: > --- > arch/powerpc/kernel/iommu.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/arch/powerpc/kernel/iommu.c b/arch/powerpc/kernel/iommu.c > index b20ff17..5abf7c3 100644 > --- a/arch/powerpc/kernel/iommu.c > +++ b/arch/powerpc/kernel/iommu.c > @@ -1149,7 +1149,8 @@ static int iommu_bus_notifier(struct notifier_block *nb, > case BUS_NOTIFY_ADD_DEVICE: > return iommu_add_device(dev); > case BUS_NOTIFY_DEL_DEVICE: > - iommu_del_device(dev); > + if (dev->iommu_group) > + iommu_del_device(dev); > return 0; > default: > return 0; >
This one seems redundant, no?
-- Alexey
| |