Messages in this thread | | | From | Pali Rohár <> | Subject | Re: [PATCH] nouveau reclocking on nv40 not working since 77145f1cbdf8d28b46ff8070ca749bad821e0774 | Date | Thu, 15 Aug 2013 19:46:26 +0200 |
| |
On Tuesday 13 August 2013 11:28:01 Pali Rohár wrote: > Hello, > > in commit 77145f1cbdf8d28b46ff8070ca749bad821e0774 was > introduced error which cause that on my Nvidia 6600GT card > reclocking not working anymore. There is missing assigment of > return value from pll_calc to ret. > > After this patch reclocking on my card working fine again. > Above broken commit was introduced in kernel 3.7, so consider > backporting this patch to older kernels too. > > Signed-off-by: Pali Rohár <pali.rohar@gmail.com> > > diff --git a/drivers/gpu/drm/nouveau/nv40_pm.c > b/drivers/gpu/drm/nouveau/nv40_pm.c index 3af5bcd..625f80d > 100644 > --- a/drivers/gpu/drm/nouveau/nv40_pm.c > +++ b/drivers/gpu/drm/nouveau/nv40_pm.c > @@ -131,7 +131,7 @@ nv40_calc_pll(struct drm_device *dev, u32 > reg, struct nvbios_pll *pll, if (clk < pll->vco1.max_freq) > pll->vco2.max_freq = 0; > > - pclk->pll_calc(pclk, pll, clk, &coef); > + ret = pclk->pll_calc(pclk, pll, clk, &coef); > if (ret == 0) > return -ERANGE;
Martin, can you look at another problem with my graphics card?
-- Pali Rohár pali.rohar@gmail.com [unhandled content-type:application/pgp-signature] | |