Messages in this thread | | | Subject | Re: [RFC PATCH 1/4] thermal: hwmon: move hwmon support to single file | From | Zhang Rui <> | Date | Thu, 15 Aug 2013 14:21:06 +0800 |
| |
Hi, Eduardo,
thanks for the patch, just one minor comments.
On 二, 2013-07-09 at 10:00 -0400, Eduardo Valentin wrote: > diff --git a/drivers/thermal/thermal_hwmon.h b/drivers/thermal/thermal_hwmon.h > new file mode 100644 > index 0000000..c798fdb > --- /dev/null > +++ b/drivers/thermal/thermal_hwmon.h > @@ -0,0 +1,49 @@ > +/* > + * thermal_hwmon.h - Generic Thermal Management hwmon support. > + * > + * Code based on Intel thermal_core.c. Copyrights of the original code: > + * Copyright (C) 2008 Intel Corp > + * Copyright (C) 2008 Zhang Rui <rui.zhang@intel.com> > + * Copyright (C) 2008 Sujith Thomas <sujith.thomas@intel.com> > + * > + * Copyright (C) 2013 Texas Instruments > + * Copyright (C) 2013 Eduardo Valentin <eduardo.valentin@ti.com> > + * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; version 2 of the License. > + * > + * This program is distributed in the hope that it will be useful, but > + * WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License along > + * with this program; if not, write to the Free Software Foundation, Inc., > + * 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA. > + * > + * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > + */ > +#ifndef __THERMAL_HWMON_H__ > +#define __THERMAL_HWMON_H__ > + > +#include <linux/thermal.h> > + > +#ifdef CONFIG_THERMAL_HWMON > +int thermal_add_hwmon_sysfs(struct thermal_zone_device *tz); > +void thermal_remove_hwmon_sysfs(struct thermal_zone_device *tz); > +#else > +static int > +thermal_add_hwmon_sysfs(struct thermal_zone_device *tz) > +{ > + return 0; > +} > + > +static void > +thermal_remove_hwmon_sysfs(struct thermal_zone_device *tz) > +{ > +} > +#endif > +
I'd prefer use "inline" here.
thanks, rui
> +#endif /* __THERMAL_HWMON_H__ */
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |