lkml.org 
[lkml]   [2013]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 23/29] drivers/i2c/busses/i2c-ocores.c: simplify use of devm_ioremap_resource
    On Wed, Aug 14, 2013 at 11:11:27AM +0200, Julia Lawall wrote:
    > From: Julia Lawall <Julia.Lawall@lip6.fr>
    >
    > Remove unneeded error handling on the result of a call to
    > platform_get_resource when the value is passed to devm_ioremap_resource.
    >
    > Move the call to platform_get_resource adjacent to the call to
    > devm_ioremap_resource to make the connection between them more clear.
    >
    > A simplified version of the semantic patch that makes this change is as
    > follows: (http://coccinelle.lip6.fr/)
    >
    > // <smpl>
    > @@
    > expression pdev,res,n,e,e1;
    > expression ret != 0;
    > identifier l;
    > @@
    >
    > - res = platform_get_resource(pdev, IORESOURCE_MEM, n);
    > ... when != res
    > - if (res == NULL) { ... \(goto l;\|return ret;\) }
    > ... when != res
    > + res = platform_get_resource(pdev, IORESOURCE_MEM, n);
    > e = devm_ioremap_resource(e1, res);
    > // </smpl>
    >
    > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

    Applied to for-next, thanks!

    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2013-08-15 16:41    [W:2.700 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site