lkml.org 
[lkml]   [2013]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v3 2/5] ARM: tegra: add support for Trusted Foundations
    On 08/12/2013 08:29 PM, Alexandre Courbot wrote:
    > Register the firmware operations for Trusted Foundations if the device
    > tree indicates it is active on the device.

    > diff --git a/arch/arm/mach-tegra/firmware.c b/arch/arm/mach-tegra/firmware.c

    > +void __init tegra_init_firmware(void)
    > +{
    > + struct device_node *node;
    > +
    > + if (!of_have_populated_dt())
    > + return;

    That's never false on Tegra, at least upstream.

    > + node = of_find_compatible_node(NULL, NULL, "tl,trusted-foundations");
    > + if (node) {
    > + const char *tf_version;
    > + int err;
    > +
    > + err = of_property_read_string(node, "version", &tf_version);
    > + if (err != 0) {
    > + pr_crit("Cannot read Trusted Foundation version: %d\n",
    > + err);
    > + BUG();
    > + } else {
    > + register_trusted_foundations(tf_version);
    > + }
    > + }
    > +}

    I think most/all of that function will be common across all SoCs that
    support the TF monitor. I think you want to move the code into
    register_trusted_foundations() (or a function that calls that) in patch 1?


    \
     
     \ /
      Last update: 2013-08-15 00:21    [W:2.595 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site