Messages in this thread | | | Date | Wed, 14 Aug 2013 10:06:08 -0600 | From | Shuah Khan <> | Subject | Re: [PATCH v2] iommu: Add event tracing feature to iommu |
| |
Hi Joerg,
Thanks for the feedback.
On 08/14/2013 08:17 AM, Joerg Roedel wrote: > Hi Shuah, > > thanks for doing this. I have a few suggestions for improvements. > > On Tue, Jul 30, 2013 at 08:57:09AM -0600, Shuah Khan wrote: >> iommu:add_device_to_group >> iommu:remove_device_from_group >> iommu:attach_device_to_domain >> iommu:detach_device_from_domain >> iommu:unmap >> iommu:map > > Please send these events as seperate patches.
Is this what you have in mind or does my original patch set minus the amd_event and drivers/iommu/amd_iommu.c change?
Patch 1: drivers/iommu/Makefile drivers/iommu/iommu-traces.c include/trace/events/iommu.h
One patch for each of the following events?
iommu:add_device_to_group iommu:remove_device_from_group iommu:attach_device_to_domain iommu:detach_device_from_domain iommu:unmap iommu:map
> >> iommu:amd_event > > This needs some more thought. For now I would prefer an event in the > generic report_iommu_fault() routine to report page-faults from all IOMMUs > that support this. >
I see what you are saying. Adding event to report_iommu_fault() would cover all IOMMUs. I would like to work on adding an event unless you already have it in works.
-- Shuah
Shuah Khan Sr. Linux Kernel Developer Open Source Group Samsung Research America(Silicon Valley) shuah.kh@samsung.com | (970) 672-0658
| |