Messages in this thread | | | Date | Wed, 14 Aug 2013 22:03:12 +0200 | From | Alexander Holler <> | Subject | Re: [PATCH 1/3] HID: Use existing parser for pre-scanning the report descriptors |
| |
Am 14.08.2013 17:38, schrieb Benjamin Tissoires:
>>> { >>> if (usage == HID_DG_CONTACTID) >>> - hid->group = HID_GROUP_MULTITOUCH; >>> + parser->flags |= HID_FLAG_MULTITOUCH; >> >> Did you consider reusing the group flags, e.g., parser->groups |= (1 >> << HID_GROUP_MULTITOUCH)? This change could be made regardless of the >> parser logic. > > If nobody is against changing the values of the different groups across > kernel version (which should be harmless), then I fully agree, we can > use the group item as a bit field (but we would be able to only have 16 > different device groups).
Hmm, that might become a problem. E.g. all the HID sensors might be used stand alone (without a sensor-hub, if someone modifies the drivers). But I agree that currently the flags are just confusing and would introduce them only if the number of groups reaches the limit.
>>> - hid->group = HID_GROUP_GENERIC; >>> + parser = vzalloc(sizeof(struct hid_parser)); >> >> Argh, I realize it is inevitable for this patch, but it still makes my >> eyes bleed. The parser takes quite a bit of memory... > > Yep, my first attempt was to remove it, then I re-added it with a small > tear...
So you actually create a new parser and the subject (that existing) of this patch is misleading.
Regards,
Alexander Holler
| |