lkml.org 
[lkml]   [2013]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] hexagon: fix return type of ffs()
On 08/07/2013 08:42 AM, Akinobu Mita wrote:
> The return type of ffs() is 'int' on all architectures except cris and
> hexagon. This unifies the return type to 'int'.
>
> The problem I'm seeing is that the following line generates a warning
> on cris and hexagon because of the mismatch between format '%u' and
> return type of ffs().
>
> printk("bits in OOB size: %u\n", ffs(ns->geom.oobsz) - 1);
>
> But removing this warning by casting to 'int' looks odd, so I suggest
> unifying the return type of ffs() on all architectures.
>
> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
> Cc: Mikael Starvik <starvik@axis.com>
> Cc: Jesper Nilsson <jesper.nilsson@axis.com>
> Cc: linux-cris-kernel@axis.com
> Cc: Richard Kuo <rkuo@codeaurora.org>
> Cc: linux-hexagon@vger.kernel.org
> Cc: linux-arch@vger.kernel.org
> ---
> This patch is not compile tested yet, because I couldn't find cross
> compiler for hexagon.
>
> arch/hexagon/include/asm/bitops.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/hexagon/include/asm/bitops.h b/arch/hexagon/include/asm/bitops.h
> index 9b1e4af..80e34a6 100644
> --- a/arch/hexagon/include/asm/bitops.h
> +++ b/arch/hexagon/include/asm/bitops.h
> @@ -234,7 +234,7 @@ static inline long fls(int x)
> * the libc and compiler builtin ffs routines, therefore
> * differs in spirit from the above ffz (man ffs).
> */
> -static inline long ffs(int x)
> +static inline int ffs(int x)
> {
> int r;
>

For Hexagon:

Acked-by: Richard Kuo <rkuo@codeaurora.org>

--

Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation



\
 
 \ /
  Last update: 2013-08-14 19:21    [W:0.043 / U:0.344 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site