Messages in this thread | | | Date | Wed, 14 Aug 2013 10:08:25 -0600 | From | Stephen Warren <> | Subject | Re: [PATCH 1/2] extcon: palmas: Added a new compatible type *ti,palmas-usb-vid* |
| |
On 08/13/2013 11:24 PM, Kishon Vijay Abraham I wrote: > Hi, > > On Wednesday 14 August 2013 12:43 AM, Stephen Warren wrote: >> On 08/12/2013 11:37 PM, Kishon Vijay Abraham I wrote: >>> The Palmas device contains only a USB VID detector, so added a >>> compatible type *ti,palmas-usb-vid*. Dint remove the existing compatible >> >> s/Dint/Didn't/ >> >>> diff --git a/Documentation/devicetree/bindings/extcon/extcon-twl.txt b/Documentation/devicetree/bindings/extcon/extcon-twl.txt >> >>> PALMAS USB COMPARATOR >>> Required Properties: >>> - - compatible : Should be "ti,palmas-usb" or "ti,twl6035-usb" >>> + - compatible : Should be "ti,palmas-usb" or "ti,twl6035-usb" or >>> + "ti,palmas-usb-vid". >> >> So are ti,palmas-usb and ti,twl6035-usb full EHCI controllers then? > > No. I thought I shouldn't remove those if someone is already using those > compatible value.
Sigh. Perhaps it's best to be consistent with the existing bad naming then:-(
| |