lkml.org 
[lkml]   [2013]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/4] drivers/misc: Support for RF interface device framework
On 8/13/2013 4:23 AM, Greg KH wrote:
> On Mon, Aug 12, 2013 at 12:43:50PM +0530, akhil.goyal@freescale.com wrote:
>> From: Akhil Goyal<akhil.goyal@freescale.com>
>>
>> The radio device framework introduces a way to accommodate the
>> RF(radio frequency) signal paths. One signal path is represented
>> as a RF device (rf0, rf1 etc), and it can contain multiple
>> components which have their individual vendor specific drivers.
>> The framework provides mechanism by which individual components
>> can register with RF framework, and the framework will handle the
>> binding of individual component devices to a RF device. RF device
>> exports the control interfaces to user space, and this user space
>> interface is independent of component (vendor specific) drivers.
>>
>> In a multimode system there can be multiple rfdev devices, depending
>> on number of radios connected.
>>
>> In this patch, the rf controller(AIC) and RFIC drivers
>> register their respective devices with this framework. This framework
>> does binding of RFIC device with RF controller device and exposes
>> the combination as a logical rfdev to user space.
>
> You are creating a bunch of character device nodes, yet there is no
> "device" behind it yet. Also, you do not export these to userspace at
> all, so no "modern" system can access these device nodes at all (hint,
> try this on your desktop system...)
>
> You should really tie into the driver model properly, to get the device
> node creation, as well as showing to userspace exactly which devices is
> connected on the "rf bus" that you need to create, because you have a
> bunch of different devices that can be attached here, with no real way
> to show userspace what is going on.
>
> Please fix up the code to do this, as it is, this is not mergable at
> all. And I'm finding it hard to understand how you tested it out...
>

Ok I will fix this in the next version.

Thanks,
Akhil




\
 
 \ /
  Last update: 2013-08-14 09:01    [W:0.082 / U:0.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site