Messages in this thread | | | Date | Wed, 14 Aug 2013 09:30:48 -0400 | From | Tejun Heo <> | Subject | Re: [PATCH 2/2] cpuset: remove redundant checks in file write functions |
| |
Hello, Li.
On Wed, Aug 14, 2013 at 10:01:32AM +0800, Li Zefan wrote: > But most controllers don't check this in those read/write functions. > It shoudn't do any harm not checking online/offline status.
It depends on the specific controller. For controllers which make clear distinction between online and offline states for, say, hierarchical config propagation, it could lead to buggy behavior if the function body afterwards assume that the current node is online. I don't know whether this is the case for the functions converted here but even if so the patch needs to update the description.
Thanks.
-- tejun
| |