lkml.org 
[lkml]   [2013]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 8/29] drivers/cpuidle/cpuidle-kirkwood.c: simplify use of devm_ioremap_resource
    Date
    On Wednesday, August 14, 2013 11:11:12 AM Julia Lawall wrote:
    > From: Julia Lawall <Julia.Lawall@lip6.fr>
    >
    > Remove unneeded error handling on the result of a call to
    > platform_get_resource when the value is passed to devm_ioremap_resource.
    >
    > A simplified version of the semantic patch that makes this change is as
    > follows: (http://coccinelle.lip6.fr/)
    >
    > // <smpl>
    > @@
    > expression pdev,res,n,e,e1;
    > expression ret != 0;
    > identifier l;
    > @@
    >
    > - res = platform_get_resource(pdev, IORESOURCE_MEM, n);
    > ... when != res
    > - if (res == NULL) { ... \(goto l;\|return ret;\) }
    > ... when != res
    > + res = platform_get_resource(pdev, IORESOURCE_MEM, n);
    > e = devm_ioremap_resource(e1, res);
    > // </smpl>
    >
    > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

    Queued up for 3.12.

    Thanks,
    Rafael


    > ---
    > drivers/cpuidle/cpuidle-kirkwood.c | 3 ---
    > 1 file changed, 3 deletions(-)
    >
    > diff --git a/drivers/cpuidle/cpuidle-kirkwood.c b/drivers/cpuidle/cpuidle-kirkwood.c
    > index 521b0a7..2237135 100644
    > --- a/drivers/cpuidle/cpuidle-kirkwood.c
    > +++ b/drivers/cpuidle/cpuidle-kirkwood.c
    > @@ -60,9 +60,6 @@ static int kirkwood_cpuidle_probe(struct platform_device *pdev)
    > struct resource *res;
    >
    > res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
    > - if (res == NULL)
    > - return -EINVAL;
    > -
    > ddr_operation_base = devm_ioremap_resource(&pdev->dev, res);
    > if (IS_ERR(ddr_operation_base))
    > return PTR_ERR(ddr_operation_base);
    >
    --
    I speak only for myself.
    Rafael J. Wysocki, Intel Open Source Technology Center.


    \
     
     \ /
      Last update: 2013-08-14 15:21    [W:4.463 / U:0.844 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site