lkml.org 
[lkml]   [2013]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/8] drm/i2c: tda998x: fix EDID reading on TDA19988 devices
From
On Wed, Aug 14, 2013 at 8:16 AM, Russell King - ARM Linux
<linux@arm.linux.org.uk> wrote:
> On Tue, Aug 06, 2013 at 12:20:11AM +0200, Sebastian Hesselbarth wrote:
>> From: Russell King <rmk+kernel@arm.linux.org.uk>
>>
>> TDA19988 devices need their RAM enabled in order to read EDID
>> information. Add support for this.
>>
>> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
>> Tested-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
>
> There was some debate about whether this is needed or not. It seems that
> if I don't run the NXP driver, it isn't needed, but if I have run the
> NXP driver, then yes it is. As it seems to do no harm, I think it's fine
> to be submitted.

just fwiw, I had noticed before that (at least on the
beaglebone-black), nxp doesn't necessarily get reset when doing a warm
reboot. So booting a kernel w/ NXP driver, and then rebooting w/
upstream kernel and tda998x should probably hit this same scenario.
Better to not assume too much about the state of the tda when the
driver is loaded, so I think this patch is a good idea.

Signed-off-by: Rob Clark <robdclark@gmail.com>

BR,
-R


\
 
 \ /
  Last update: 2013-08-14 14:41    [W:0.156 / U:0.376 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site