lkml.org 
[lkml]   [2013]   [Aug]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v5] media: i2c: tvp7002: add OF support
On Tue, Aug 13, 2013 at 6:30 AM, Kumar Gala <galak@codeaurora.org> wrote:
>
> On Aug 11, 2013, at 1:25 AM, Lad, Prabhakar wrote:
>
>> From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
>>
>> add OF support for the tvp7002 driver.
>>
>> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
>> ---
>> This patch depends on https://patchwork.kernel.org/patch/2842680/
>>
>> Changes for v5:
>> 1: Fixed review comments pointed by Hans.
>>
>> Changes for v4:
>> 1: Improved descrition of end point properties.
>>
>> Changes for v3:
>> 1: Fixed review comments pointed by Sylwester.
>>
>> .../devicetree/bindings/media/i2c/tvp7002.txt | 53 ++++++++++++++++
>> drivers/media/i2c/tvp7002.c | 67 ++++++++++++++++++--
>> 2 files changed, 113 insertions(+), 7 deletions(-)
>> create mode 100644 Documentation/devicetree/bindings/media/i2c/tvp7002.txt
>>
>> diff --git a/Documentation/devicetree/bindings/media/i2c/tvp7002.txt b/Documentation/devicetree/bindings/media/i2c/tvp7002.txt
>> new file mode 100644
>> index 0000000..5f28b5d
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/media/i2c/tvp7002.txt
>> @@ -0,0 +1,53 @@
>> +* Texas Instruments TV7002 video decoder
>> +
>> +The TVP7002 device supports digitizing of video and graphics signal in RGB and
>> +YPbPr color space.
>> +
>> +Required Properties :
>> +- compatible : Must be "ti,tvp7002"
>> +
>> +Optional Properties:
>
>
>> +- hsync-active: HSYNC Polarity configuration for the bus. Default value when
>> + this property is not specified is <0>.
>> +
>> +- vsync-active: VSYNC Polarity configuration for the bus. Default value when
>> + this property is not specified is <0>.
>> +
>> +- pclk-sample: Clock polarity of the bus. Default value when this property is
>> + not specified is <0>.
>> +
>> +- sync-on-green-active: Active state of Sync-on-green signal property of the
>> + endpoint.
>> + 0 = Normal Operation (Active Low, Default)
>> + 1 = Inverted operation
>
> These seems better than what you have in video-interfaces.txt
>
Well it sounds the same, I would keep it as is, let me know if you still
want me to change.

>> +
>> +- field-even-active: Active-high Field ID output polarity control of the bus.
>> + Under normal operation, the field ID output is set to logic 1 for an odd field
>> + (field 1) and set to logic 0 for an even field (field 0).
>> + 0 = Normal Operation (Active Low, Default)
>> + 1 = FID output polarity inverted
>> +
>
> Why the duplication if this is covered in video-interfaces.txt?
>
The explanation in video-interfaces.txt is more kind of generic and
the explanation
here is specific to this device.

Regards,
--Prabhakar Lad


\
 
 \ /
  Last update: 2013-08-13 05:01    [W:0.091 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site