lkml.org 
[lkml]   [2013]   [Aug]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Review [2/2] Staging: BCM: Removed more whitespace/Errors
On Thu, Aug 08, 2013 at 06:35:32PM +0100, Paul McQuade wrote:
> From 9f6231ce16996e35545e20ce1d91abc058f2a6fb Mon Sep 17 00:00:00 2001
> From: Paul McQuade <paulmcquad@gmail.com>
> Date: Thu, 8 Aug 2013 17:49:22 +0100
> Subject: [PATCH 2/2] Staging: BCM: Removed more whitespace/Errors

Why is this duplicated here?

Just use 'git send-email' to send patches out, that way this isn't a
problem, and also:

> drivers/staging/bcm/InterfaceMacros.h | 6 +-
> drivers/staging/bcm/InterfaceMisc.h | 14 +--
> drivers/staging/bcm/InterfaceRx.c | 166
> ++++++++++++++-------------------

Your patch is line-wrapped, making it impossible to apply :(

The whitespace is also all broken.

Take a look at the kernel file, Documentation/email_clients.txt for how
to fix this up properly.

thanks,

greg k-h


\
 
 \ /
  Last update: 2013-08-13 00:41    [W:0.161 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site