[lkml]   [2013]   [Aug]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] mmc: dw_mmc: Don't disable vmmc if keeping power in suspend
Seungwon and Derek,

On Mon, Aug 12, 2013 at 3:33 AM, Seungwon Jeon <> wrote:
> On Wed, August 07, 2013, Derek Basehore
>> If we keep power for suspend on a host for dw_mmc, don't disable vmmc-supply
>> regulator when suspending the host.
> I have a trivial comment.
> It would be better to add some macro for checking MMC_PM_KEEP_POWER.
> And I just wonder how the problem is silent. Origin code has stood up somewhat long.
> Did you see?
> Acked-by: Seungwon Jeon <>
> Thanks,
> Seungwon Jeon
>> Signed-off-by: Derek Basehore <>
>> Reviewed-by: Doug Anderson <>
>> ---
>> drivers/mmc/host/dw_mmc.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)

Though I reviewed this originally, I'd actually propose not landing it.

I've spent more time with the regulator code in dw_mmc and currently
believe that the regulators should be enabled / disabled in
MMC_POWER_UP / MMC_POWER_OFF. When we do that then the mmc core will
handle MMC_PM_KEEP_POWER. You can see my current thoughts on this in
<>. I will try to post
that upstream before too long, but feel free to let me know any


 \ /
  Last update: 2013-08-12 20:01    [W:0.125 / U:0.184 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site