lkml.org 
[lkml]   [2013]   [Aug]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] pinctrl: pinmux: Don't free pins requested by other devices in pinmux_disable_setting.
On 08/12/2013 12:10 AM, Sonic Zhang wrote:
> From: Sonic Zhang <sonic.zhang@analog.com>
>
> One peripheral may share part of its pins with the 2nd
> peripheral and the other pins with the 3rd. If it requests all pins
> when part of them has already be requested and owned by the 2nd
> peripheral, this request fails and pinmux_disable_setting() is called.
> The pinmux_disable_setting() frees all pins of the first peripheral
> without checking if the pin is owned by itself or the 2nd, which
> results in the malfunction of the 2nd peripheral driver.

This patch looks conceptually fine at a quick glance, but ...

> diff --git a/drivers/pinctrl/core.h b/drivers/pinctrl/core.h

> @@ -154,6 +154,7 @@ struct pin_desc {
> const char *mux_owner;
> const struct pinctrl_setting_mux *mux_setting;
> const char *gpio_owner;
> + const struct pinctrl_setting *owning_setting

... I think you can use the existing "mux_setting" field instead of
adding a new "owning_setting" field.


\
 
 \ /
  Last update: 2013-08-12 20:01    [W:0.049 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site