lkml.org 
[lkml]   [2013]   [Aug]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] mm/hotplug: Verify hotplug memory range
From
Date
On Mon, 2013-08-12 at 07:37 +0800, Wanpeng Li wrote:
> On Sat, Aug 10, 2013 at 01:17:32PM -0600, Toshi Kani wrote:
> >add_memory() and remove_memory() can only handle a memory range aligned
> >with section. There are problems when an unaligned range is added and
> >then deleted as follows:
> >
> > - add_memory() with an unaligned range succeeds, but __add_pages()
> > called from add_memory() adds a whole section of pages even though
> > a given memory range is less than the section size.
> > - remove_memory() to the added unaligned range hits BUG_ON() in
> > __remove_pages().
> >
> >This patch changes add_memory() and remove_memory() to check if a given
> >memory range is aligned with section at the beginning. As the result,
> >add_memory() fails with -EINVAL when a given range is unaligned, and
> >does not add such memory range. This prevents remove_memory() to be
> >called with an unaligned range as well. Note that remove_memory() has
> >to use BUG_ON() since this function cannot fail.
> >
> >Signed-off-by: Toshi Kani <toshi.kani@hp.com>
> >Acked-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
> >Reviewed-by: Tang Chen <tangchen@cn.fujitsu.com>
>
> Reviewed-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>

Thanks Wanpeng!
-Toshi



\
 
 \ /
  Last update: 2013-08-12 17:01    [W:0.102 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site