lkml.org 
[lkml]   [2013]   [Aug]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH part2 2/4] earlycpio.c: Fix the confusing comment of find_cpio_data().
On Thu, Aug 08, 2013 at 01:03:57PM +0800, Tang Chen wrote:
> The comments of find_cpio_data() says:
>
> * @offset: When a matching file is found, this is the offset to the
> * beginning of the cpio. ......
>
> But according to the code,
>
> dptr = PTR_ALIGN(p + ch[C_NAMESIZE], 4);
> nptr = PTR_ALIGN(dptr + ch[C_FILESIZE], 4);
> ....
> *offset = (long)nptr - (long)data; /* data is the cpio file */
>
> @offset is the offset of the next file, not the matching file itself.
> This is confused and may cause unnecessary waste of time to debug.
> So fix it.
>
> v1 -> v2:
> As tj suggested, rename @offset to @nextoff which is more clear to
> users. And also adjust the new comments.
>
> Signed-off-by: Tang Chen <tangchen@cn.fujitsu.com>
> Reviewed-by: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>

Reviewed-by: Tejun Heo <tj@kernel.org>

Thanks.

--
tejun


\
 
 \ /
  Last update: 2013-08-12 16:41    [W:0.091 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site