lkml.org 
[lkml]   [2013]   [Aug]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH part2 3/4] acpi: Remove "continue" in macro INVALID_TABLE().
On Thu, Aug 08, 2013 at 07:09:53AM -0700, Joe Perches wrote:
> If you really think that the #define is better, use
> something like HW_ERR does and embed that #define
> in the pr_err.
>
> #define ACPI_OVERRIDE "ACPI OVERRIDE: "
>
> pr_err(ACPI_OVERRIDE "Table smaller than ACPI header [%s%s]\n",
> cpio_path, file.name);
>
> It's only used a few times by a single file so
> I think it's unnecessary.

I agree with Joe here. Just doing normal pr_err() should be enough.
You can use pr_fmt() to add headers but given that we aren't talking
about huge number of printks, that probably is an overkill too.

Thanks.

--
tejun


\
 
 \ /
  Last update: 2013-08-12 16:41    [W:0.149 / U:0.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site